Do not render expansion panel description if unused (#1129)

google · Dec 5, 2024 · 721219a · 721219a
1 parent 5212217
commit 721219a
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/mesop/components/expansion_panel/e2e/expansion_panel_app.py b/mesop/components/expansion_panel/e2e/expansion_panel_app.py
@@ -38,8 +38,7 @@ def app():
       me.text("Pineapple content.")
 
     with me.expansion_panel(
-      title="Cantalope title",
-      description="Type of fruit",
+      title="Cantalope (no description)",
       hide_toggle=True,
     ):
       me.text("Cantalope content.")

diff --git a/mesop/components/expansion_panel/e2e/expansion_panel_test.ts b/mesop/components/expansion_panel/e2e/expansion_panel_test.ts
@@ -23,7 +23,7 @@ test.describe('Expansion Panel', () => {
       await page
         .locator('[aria-disabled="false"] span.mat-content-hide-toggle')
         .textContent(),
-    ).toContain('Cantalope title');
+    ).toContain('Cantalope (no description)');
   });
 });
 

diff --git a/mesop/components/expansion_panel/expansion_panel.ng.html b/mesop/components/expansion_panel/expansion_panel.ng.html
@@ -8,11 +8,13 @@
 >
   <mat-expansion-panel-header>
     <mat-panel-title>{{config().getTitle()}}</mat-panel-title>
+    @if (config().getDescription()) {
     <mat-panel-description>
       {{config().getDescription()}} @if (config().getIcon()) {
       <mat-icon>{{config().getIcon()}}</mat-icon>
       }
     </mat-panel-description>
+    }
   </mat-expansion-panel-header>
   <ng-content></ng-content>
 </mat-expansion-panel>