Improve error box developer experience (#202)

google · May 9, 2024 · 0969908 · 0969908
1 parent 319f4f5
commit 0969908
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/mesop/web/src/shell/shell.ng.html b/mesop/web/src/shell/shell.ng.html
@@ -1,6 +1,5 @@
-@for(error of this.errors; track $index) {
 <mesop-error-box *ngIf="error != null" [error]="error" />
-}
+
 <div class="status">
   <mat-progress-bar
     data-testid="connection-progress-bar"

diff --git a/mesop/web/src/shell/shell.ts b/mesop/web/src/shell/shell.ts
@@ -42,7 +42,7 @@ import {GlobalErrorHandlerService} from '../services/global_error_handler';
 })
 export class Shell {
   rootComponent!: ComponentProto;
-  errors: ServerError[] = [];
+  error: ServerError | undefined;
   componentConfigs: readonly ComponentConfig[] = [];
 
   constructor(
@@ -57,7 +57,7 @@ export class Shell {
     (errorHandler as GlobalErrorHandlerService).setOnError((error) => {
       const errorProto = new ServerError();
       errorProto.setException(`JS Error: ${error.toString()}`);
-      this.errors.push(errorProto);
+      this.error = errorProto;
     });
   }
 
@@ -67,12 +67,13 @@ export class Shell {
       onRender: (rootComponent, componentConfigs) => {
         this.rootComponent = rootComponent;
         this.componentConfigs = componentConfigs;
+        this.error = undefined;
       },
       onNavigate: (route) => {
         this.router.navigateByUrl(route);
       },
       onError: (error) => {
-        this.errors.push(error);
+        this.error = error;
       },
     });
   }