Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix BatchesFromExecutions #111

Merged
merged 3 commits into from
Oct 20, 2022
Merged

Fix BatchesFromExecutions #111

merged 3 commits into from
Oct 20, 2022

Conversation

diogoaihara
Copy link
Contributor

  • size estimation overflow
  • filter by destination type in process func

Mr-Lopes
Mr-Lopes reviewed Oct 19, 2022
View reviewed changes
Copy link
Collaborator

@Mr-Lopes Mr-Lopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this! Could you provide a brief description/comments to the comments below?

megalista_dataflow/sources/batches_from_executions.py Show resolved Hide resolved
megalista_dataflow/sources/batches_from_executions.py Outdated Show resolved Hide resolved
Mr-Lopes
Mr-Lopes approved these changes Oct 19, 2022
View reviewed changes
Copy link
Collaborator

@Mr-Lopes Mr-Lopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diogoaihara diogoaihara merged commit 105e6ee into main Oct 20, 2022
@diogoaihara diogoaihara deleted the batch_size branch October 20, 2022 14:52
diogoaihara added a commit that referenced this pull request Oct 20, 2022
@diogoaihara
Fix BatchesFromExecutions (#111)
c994000 
* Fix BatchesFromExecutions: size estimation overflow + filter by destination type in process func
* Explanation about estimate_size
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mr-Lopes Mr-Lopes Mr-Lopes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diogoaihara @Mr-Lopes