Few Rust fixes #726
Merged
Few Rust fixes #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ia0
commented
Sep 26, 2024
•
ia0
commented
- Fix build on recent nightly.
- Fix publish script to correctly update changelog files.
- Don't cross-compile since the CI does it.
- Removing myself from default code owners (keeping only Rust).
- Fix build on recent nightly. - Fix publish script to correctly update changelog files. - Don't cross-compile since the CI does it.
reyammer
approved these changes
Sep 26, 2024
ia0
added a commit
to ia0/magika
that referenced
this pull request
Oct 18, 2024
It was disabled by google#726 due to a false positive tracked and fixed by rust-lang/rust-clippy#13458.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.