Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Ruby phonelib third-party interface #2873

Merged
merged 2 commits into from
Feb 10, 2023
Merged

Conversation

espen
Copy link
Contributor

@espen espen commented Jan 8, 2023

No description provided.

@google-cla
Copy link

google-cla bot commented Jan 8, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@penmetsaa penmetsaa self-requested a review January 24, 2023 05:19
@penmetsaa
Copy link
Contributor

Hi,
Thanks so much for listing your port here.
We would like to know how it is different and improvements over existing Ruby ports.

@espen
Copy link
Contributor Author

espen commented Jan 24, 2023

It's not my implementation. @daddyz can perhaps answer your question.

@daddyz
Copy link

daddyz commented Jan 24, 2023

@penmetsaa It's not a fork, it implements different parsing logic based on same data.
mini_phone - plugs directly into Google's native C++
telephone_number - ruby fork based on the library
phonelib - is implemented with same phone parsing logic inside, but has extended functionality, it knows how to guess the country, it integrates with ActiveRecord validations, it has option to be extended by additional regexes (the ones that are not yet included in libphonenumber). I started it 10 years ago, when there was no real way to use libphonenumber in ruby, and it grew up in separate project.

@penmetsaa
Copy link
Contributor

Hi,
Thanks so much for the info.
Will merge this shortly, presently we are in middle of release cycle.

@penmetsaa penmetsaa merged commit ec709a2 into google:master Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants