Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support basic math NumPy functions #49

Merged
merged 8 commits into from
Oct 14, 2022
Merged

Support basic math NumPy functions #49

merged 8 commits into from
Oct 14, 2022

Conversation

Raphael-CV
Copy link
Contributor

@Raphael-CV Raphael-CV commented Oct 12, 2022

Support basic math NumPy functions

@google-cla
Copy link

google-cla bot commented Oct 12, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Raphael-CV
Copy link
Contributor Author

@googlebot I signed it.

Copy link
Collaborator

@odashi odashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It looks the title of this pull request seems to be "support NumPy functions" because this change does really not support the whole stuff in NumPy.

@Raphael-CV Raphael-CV changed the title Numpy support Support basic math NumPy functions Oct 13, 2022
@Raphael-CV Raphael-CV changed the title Support basic math NumPy functions Some improvements Oct 13, 2022
@odashi
Copy link
Collaborator

odashi commented Oct 13, 2022

@Raphael-CV If you have several ideas to implement, is it possible to propose separate pull requests for each idea? Mixed pull requests are sometimes difficult to maintain and I think we need to focus on the feature about NumPy functions in this specific pull request.

@Raphael-CV
Copy link
Contributor Author

It seems indeed that it is a better idea. I revert the last commits and will propose several pull requests.

@Raphael-CV Raphael-CV changed the title Some improvements Support basic math NumPy functions Oct 14, 2022
@odashi
Copy link
Collaborator

odashi commented Oct 14, 2022

@Raphael-CV Thanks a lot!

@odashi odashi added this to the v0.2 milestone Oct 14, 2022
@odashi odashi merged commit 9307e6e into google:main Oct 14, 2022
@odashi odashi added the feature label Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants