-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support basic math NumPy functions #49
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
@googlebot I signed it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! It looks the title of this pull request seems to be "support NumPy functions" because this change does really not support the whole stuff in NumPy.
@Raphael-CV If you have several ideas to implement, is it possible to propose separate pull requests for each idea? Mixed pull requests are sometimes difficult to maintain and I think we need to focus on the feature about NumPy functions in this specific pull request. |
It seems indeed that it is a better idea. I revert the last commits and will propose several pull requests. |
@Raphael-CV Thanks a lot! |
Support basic math NumPy functions