Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix behavior of sum/prod with no arguments #194

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Fix behavior of sum/prod with no arguments #194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/latexify/codegen/expression_codegen.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ def _generate_sum_prod(self, node: ast.Call) -> str | None:
Returns:
Generated LaTeX, or None if the node has unsupported syntax.
"""
if not isinstance(node.args[0], ast.GeneratorExp):
if not node.args or not isinstance(node.args[0], ast.GeneratorExp):
return None

name = ast_utils.extract_function_name_or_none(node)
Expand Down
2 changes: 2 additions & 0 deletions src/latexify/codegen/expression_codegen_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,8 @@ def test_visit_call(code: str, latex: str) -> None:
@pytest.mark.parametrize(
"src_suffix,dest_suffix",
[
# No arguments
("()", r" \mathopen{}\left( \mathclose{}\right)"),
# No comprehension
("(x)", r" x"),
(
Expand Down