Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add isort module to checks script and Github CI #120

Merged
merged 6 commits into from
Nov 18, 2022
Merged

Add isort module to checks script and Github CI #120

merged 6 commits into from
Nov 18, 2022

Conversation

jianan1104
Copy link
Contributor

Overview

Add isort module to check python import order and format identically

Details

  • add isort module to development environment
  • using isort to refactor the code
  • add isort check to checks.sh
  • add isort step to Github CI

odashi
odashi approved these changes Nov 18, 2022
View reviewed changes
Copy link
Collaborator

@odashi odashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@odashi odashi merged commit 8bb0244 into google:main Nov 18, 2022
@jianan1104 jianan1104 deleted the add-isort-module branch November 21, 2022 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odashi odashi odashi approved these changes

Assignees
No one assigned
Labels
refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jianan1104 @odashi