New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Guava version to 33.2.0. #1931

Merged

ting-yuan merged 1 commit into google:main from ting-yuan:guava

May 28, 2024

Collaborator

ting-yuan commented May 28, 2024

No description provided.


          Bump Guava version to 33.2.0.

52559c8

ting-yuan requested a review from neetopia

May 28, 2024 20:05

Collaborator Author

ting-yuan commented May 28, 2024 •

edited

Loading

Temporarily fixes #1911, where KSP's dependency of older Guava polluted the classpath. There are a few options:

Do not bundle Guava. However, because of the isolating classloader, KSP still needs to specify a version of Guava manually and cannot let Gradle decide it. There is no difference from bundling Guava from the processor's point of view.
Implement a special classloader that does some filtering. This is a bit complicated but may be the solution in the long run.
(this patch) Bump Guava version and assume that it is backward compatible.

neetopia approved these changes

View reviewed changes

ting-yuan merged commit 3f13a8e into google:main

3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet