use psi based type reference to defer type resolution #1506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ting-yuan
reviewed
Aug 24, 2023
...sis-api/src/main/kotlin/com/google/devtools/ksp/impl/symbol/kotlin/KSClassDeclarationImpl.kt
Outdated
Show resolved
Hide resolved
| @@ -15,18 +17,18 @@ class KSCallableReferenceImpl private constructor( | |||
| cache.getOrPut(IdKeyPair(ktFunctionalType, parent)) { KSCallableReferenceImpl(ktFunctionalType, parent) } | |||
| } | |||
| override val receiverType: KSTypeReference? | |||
| get() = ktFunctionalType.receiverType?.let { KSTypeReferenceImpl.getCached(it) } | |||
| get() = ktFunctionalType.receiverType?.let { KSTypeReferenceResolvedImpl.getCached(it) } | |||
There was a problem hiding this comment.
For the purpose of deferring and restoring, all type references in sources (be it java or kotlin) need to be implemented by KSTypeReferenceImpl.
There was a problem hiding this comment.
Also, KSCallableReferenceImpl can not take KtFunctionalType for sources, because it is subject to change.
There was a problem hiding this comment.
KtCallableReference is left as TODO in this PR.
.../src/main/kotlin/com/google/devtools/ksp/impl/symbol/kotlin/KSPropertyDeclarationJavaImpl.kt
Show resolved
Hide resolved
neetopia
force-pushed
the
type-ref-refactor
branch
from
7ed007e
to
9717019
Compare
neetopia
force-pushed
the
type-ref-refactor
branch
2 times, most recently
from
758d9a2
to
9f63e90
Compare
neetopia
force-pushed
the
type-ref-refactor
branch
from
9f63e90
to
3c1efde
Compare
|
|
neetopia
force-pushed
the
type-ref-refactor
branch
from
3c1efde
to
42b7643
Compare
ting-yuan
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.