explicit constructor is missing in compiled java dependencies #273
Comments
|
looks very similar to this fix: https://github.com/google/ksp/pull/266/files#diff-01b42eb0e075a0c870d622cf579ee1453926dc405c41ca55eb0813e1baa9a743R770 |
yigit
added a commit
to yigit/ksp
that referenced
this issue
Jan 28, 2021
This PR fixes a bunch of issues / inconsistencies in constuctor
delcarations.
* changed KSFunctionDeclarationImpl and KSFunctionDeclarationJavaImpl
to return <init> from name if it is constructor for consistency
* added KSFunctionDeclaration.isConstructor extension function for
convenience
* changed getConstructors to simply use
declaredFunctions.filter { it.kind == CONSTURCTOR } for consistency
* updated KSClassDeclarationDescriptorImpl.kt declarations to include
* added synthetic constructors for non-interface classes that do not
have a constructor (including java annotations which do get a
constructor when they are in .class files)
* fixed KSConstructorSyntheticImpl to implement returnType
Fixes: google#273
Fixes: google#114
Fixes: google#113
Test: constructorDeclarations.kt
copybara-service bot
pushed a commit
to androidx/androidx
that referenced
this issue
Feb 6, 2021
* Removed workarounds in KspTypeElement about detecting constructors since KSP now has an API to get check if a function is a constructor * Removed the workaround for google/ksp#175 which seems to be working now. Instead, now we revert some override calls if its jvm signatures won't match. * Updated ksp integration test (room kotlin test app) to use the new kspAndroidTest conffiguration. * Removed the workaround for google/ksp#173 * Re-enabled @generated annotation for KSP: google/ksp#198 * Removed the log for https://github.com/android/kotlin/issues/133 We'll still use custom logic because calling KSP will invoke the descriptor APIs and current implementation is working fine. * Fallback location test now also checks the KSP constructor case google/ksp#273 Bug: 160322705 Test: existing tests Change-Id: I1aef81b0c7475a86d40d38456e765a469ca79de6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Seems like when a dependency has a java class with an excplicit constructor, it doesn't get reported from ksp.
repro: yigit@3c43627
Will work on the fix, not sure what is happening right now.
The text was updated successfully, but these errors were encountered: