Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

completion results for non-loaded classes #46

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eugen-yakovets
Copy link
Contributor

  • Add scan command for scanning all classes in classpath (non only already loaded by classloader)
  • Use classpath scan result for command completion

@gharrma
Copy link
Collaborator

gharrma commented Feb 23, 2022

Thanks for the PR. I haven't look too deeply at the implementation, but I did try out the feature.

I think the performance of scan is a blocking issue, unfortunately. For me at least it froze the IDE for a few minutes and triggered low-memory warnings :). I could increase my heap size, but ideally it shouldn't be needed. Do you think it is possible to improve the performance? Or is the problem just that there are so many classes to scan through?

Note, I also noticed performance regressions for other commands, even without using scan at all. It seems there is some additional reflection happening ClassMethods.tryCreate now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants