Create a config tab to show user trace requests #42

obask · 2021-11-01T18:05:30Z

add global TracerUserConfig to store raw user requests
changed TraceTarget.Method to duplicate traceOption state
since this information isn't available in MethodFqMatcher

google-cla · 2021-11-01T18:05:38Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

gharrma · 2021-11-02T01:15:12Z

src/main/java/com/google/idea/perf/tracer/ui/TracerPanel.kt

@@ -239,6 +243,7 @@ class TracerPanel(
        val stats = CallTreeUtil.computeFlatTracepointStats(treeSnapshot)
        listView.setTracepointStats(stats)
        treeView.setCallTree(treeSnapshot)
+        configView.setTracingConfig(TracerUserConfig.cloneUserTraceRequests())


Should this call be moved into TracerController (after new tracing commands are issued), rather than here inside the render loop?

configView seems similar to previous set calls in the same function. Controller wouldn't have access to it. Could you elaborate please if you think it's worth moving a call?

gharrma · 2021-11-02T01:26:01Z

src/main/java/com/google/idea/perf/tracer/ui/TracerConfigModel.kt

+import kotlin.math.min
+
+/** The table model for [TracerTable]. */
+class TracerConfigModel : AbstractTableModel() {


Since we are displaying mostly-static information, would it be simpler to just display a text field that lists the tracing commands issued so far?

gharrma · 2021-11-02T01:29:35Z

src/main/java/com/google/idea/perf/tracer/TracerUserConfig.kt

+
+    fun addUserTraceRequest(entry: TraceTarget.Method) {
+        val sortKey = concatClassAndMethod(entry)
+        userTraceRequests[sortKey] = entry


It might be nice to display commands in the order that they were issued (since the order has meaning --- later commands take precedence over earlier commands).

google-cla · 2021-11-05T19:52:35Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-11-05T20:12:36Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-11-05T20:18:19Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-11-05T20:22:56Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

add global TracerUserConfig to store raw user requests changed TraceTarget.Method to duplicate traceOption state since this information isn't available in MethodFqMatcher created a unit test for a UI component increased -XX:ReservedCodeCacheSize

gharrma reviewed Nov 2, 2021

View reviewed changes

obask force-pushed the create-config-tab branch from 934e034 to bdf6a5b Compare November 5, 2021 20:18

obask force-pushed the create-config-tab branch from bdf6a5b to ee62063 Compare November 5, 2021 20:22

obask force-pushed the create-config-tab branch from ee62063 to 064f5e5 Compare November 5, 2021 20:42

obask force-pushed the create-config-tab branch from 064f5e5 to ad0ea7a Compare August 16, 2022 19:55

obask force-pushed the create-config-tab branch from ad0ea7a to f842103 Compare August 16, 2022 21:51

obask marked this pull request as ready for review August 16, 2022 21:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create a config tab to show user trace requests #42

Create a config tab to show user trace requests #42

obask commented Nov 1, 2021

google-cla bot commented Nov 1, 2021

gharrma Nov 2, 2021

obask Aug 16, 2022

gharrma Nov 2, 2021

obask Aug 16, 2022

gharrma Nov 2, 2021

obask Aug 17, 2022

google-cla bot commented Nov 5, 2021

google-cla bot commented Nov 5, 2021

google-cla bot commented Nov 5, 2021

google-cla bot commented Nov 5, 2021

Create a config tab to show user trace requests #42

Are you sure you want to change the base?

Create a config tab to show user trace requests #42

Conversation

obask commented Nov 1, 2021

google-cla bot commented Nov 1, 2021

What to do if you already signed the CLA

Individual signers

Corporate signers

gharrma Nov 2, 2021

Choose a reason for hiding this comment

obask Aug 16, 2022

Choose a reason for hiding this comment

gharrma Nov 2, 2021

Choose a reason for hiding this comment

obask Aug 16, 2022

Choose a reason for hiding this comment

gharrma Nov 2, 2021

Choose a reason for hiding this comment

obask Aug 17, 2022

Choose a reason for hiding this comment

google-cla bot commented Nov 5, 2021

What to do if you already signed the CLA

Individual signers

Corporate signers

google-cla bot commented Nov 5, 2021

What to do if you already signed the CLA

Individual signers

Corporate signers

google-cla bot commented Nov 5, 2021

What to do if you already signed the CLA

Individual signers

Corporate signers

google-cla bot commented Nov 5, 2021

What to do if you already signed the CLA

Individual signers

Corporate signers