Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review comments for AI UI #1948

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Review comments for AI UI #1948

merged 1 commit into from
Jan 10, 2024

Conversation

yschimke
Copy link
Collaborator

@yschimke yschimke commented Jan 8, 2024 •
edited
Loading

WHAT

Review comments for AI UI

WHY

HOW

Checklist 📋

  • Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • Update metalava's signature text files

@yschimke yschimke requested a review from fstanis January 8, 2024 16:35
@yschimke yschimke marked this pull request as ready for review January 8, 2024 16:35
@yschimke yschimke requested a review from luizgrp January 10, 2024 09:05
@yschimke yschimke merged commit 883acff into google:main Jan 10, 2024
4 checks passed
@yschimke yschimke deleted the review_comments branch February 13, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luizgrp luizgrp luizgrp approved these changes

@fstanis fstanis Awaiting requested review from fstanis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yschimke @luizgrp