Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move datalayer sample to datalayer sample app #1852

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Move datalayer sample to datalayer sample app #1852

merged 1 commit into from
Dec 5, 2023

Conversation

luizgrp
Copy link
Member

@luizgrp luizgrp commented Dec 5, 2023

WHAT

Move datalayer sample to datalayer sample app.

WHY

Fixes #1808

Checklist 📋

  • Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • Update metalava's signature text files

@luizgrp luizgrp self-assigned this Dec 5, 2023
yschimke
yschimke reviewed Dec 5, 2023
View reviewed changes
datalayer/sample/wear/build.gradle.kts

protobuf {
protoc {
artifact = "com.google.protobuf:protoc:3.25.1"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For later - we should grab these from the version catalog also.

@yschimke yschimke merged commit 4d2bb6b into google:main Dec 5, 2023
4 checks passed
@luizgrp luizgrp deleted the datalayer_move_sample branch December 5, 2023 10:22
oas004 pushed a commit to oas004/horologist that referenced this pull request Dec 5, 2023
@luizgrp @oas004
Move datalayer sample to datalayer sample app (google#1852)
df9d382
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yschimke yschimke yschimke approved these changes

Assignees

@luizgrp luizgrp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create separated sample apps for datalayer
2 participants
@luizgrp @yschimke