Add iconRtlMode param to Chip API #1850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oas004
commented
Dec 4, 2023
compose-material/src/debug/java/com/google/android/horologist/compose/material/ChipPreview.kt
Outdated
Show resolved
Hide resolved
oas004
commented
Dec 4, 2023
compose-material/src/test/java/com/google/android/horologist/compose/material/ChipTest.kt
Show resolved
Hide resolved
oas004
force-pushed
the
add-rtl-mode-chip
branch
4 times, most recently
from
1ca55cd to
77cf675
Compare
luizgrp
reviewed
Dec 5, 2023
compose-material/src/debug/java/com/google/android/horologist/compose/material/ChipPreview.kt
Outdated
Show resolved
Hide resolved
compose-material/src/test/java/com/google/android/horologist/compose/material/ChipTest.kt
Show resolved
Hide resolved
compose-material/src/test/java/com/google/android/horologist/compose/material/ChipTest.kt
Show resolved
Hide resolved
...napshots/images/com.google.android.horologist.compose.material_ChipTest_withIconMirrored.png
Outdated
Show resolved
Hide resolved
oas004
force-pushed
the
add-rtl-mode-chip
branch
2 times, most recently
from
df9d382 to
2def5d3
Compare
oas004
force-pushed
the
add-rtl-mode-chip
branch
from
dddd152 to
a7a9b3a
Compare
4 tasks
luizgrp
approved these changes
Dec 7, 2023
compose-material/src/test/java/com/google/android/horologist/compose/material/ChipTest.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Add iconRtlMode param to Chip API and move chip to use the internal horologist material icon implementation.
WHY
#1671
HOW
Add iconRtlModeParam to chip. Then start using it in the icon implementation. Then add preview and Screenshot test.
Plan is to do the same with OutlinedChip in a separate PR :)
Checklist 📋