Add material components to the sample application #1844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oas004
force-pushed
the
feature/material-components-sample
branch
from
39e55f7 to
be4501b
Compare
|
I'm a bit unsure if I should collect them somehow 🤔 Does it maybe make more sense to have like a chip screen that has all the chips and compact chips? And the same with buttons and toggleButtons I guess? 🤔 Wdyt? |
oas004
force-pushed
the
feature/material-components-sample
branch
from
be4501b to
7ef6f9d
Compare
oas004
commented
Dec 1, 2023
sample/src/main/java/com/google/android/horologist/sample/Screen.kt
Outdated
Show resolved
Hide resolved
I like the way you've built here with one single component per screen, I find it less confusing from my "dev" perspective! |
luizgrp
approved these changes
Dec 4, 2023
sample/src/main/java/com/google/android/horologist/materialcomponents/SampleTitleScreen.kt
Outdated
Show resolved
Hide resolved
sample/src/main/java/com/google/android/horologist/materialcomponents/SampleIconScreen.kt
Outdated
Show resolved
Hide resolved
oas004
force-pushed
the
feature/material-components-sample
branch
from
bdfb452 to
833dc48
Compare
oas004
added a commit
to oas004/horologist
that referenced
this pull request
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Add material components to the sample application
WHY
Would be nice to have a sample to see how the components look on a real device
HOW
Adding all the components under
compose-materialto the sample applicationChecklist 📋