Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of RotaryScrollAdapter for AndroidX Picker #1689

Merged
merged 3 commits into from
Sep 18, 2023

Conversation

yschimke
Copy link
Collaborator

WHAT

Small Picker API for RotaryScrollAdapter

WHY

Picker and PickerState are public APIs, so the internal implementations used by DatePicker and TimePicker should remain so.

HOW

Checklist 📋

  • Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • Update metalava's signature text files

@Kpeved
Copy link
Collaborator

Kpeved commented Sep 18, 2023

Why it's called "Small picker" ? I guess would be better to have something like " Implementation of RotaryScrollAdapter for AndroidX Picker. "

@@ -55,3 +56,41 @@ internal class PickerRotaryScrollAdapter(
override fun totalItemsCount(): Int =
scrollableState.scalingLazyListState.layoutInfo.totalItemsCount
}

/**
* Temporary implementation of RotaryScrollAdapter for PickerState.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to add "PickerState from AndroidX wear-compose library"

@yschimke yschimke changed the title Small Picker API for RotaryScrollAdapter Implementation of RotaryScrollAdapter for AndroidX Picker Sep 18, 2023
@yschimke yschimke merged commit 4b86b8f into google:main Sep 18, 2023
3 of 4 checks passed
@yschimke yschimke deleted the picker_api branch October 6, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants