-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fails to build on riscv without RVV 1.0 despite #2159 #2227
Comments
Hi @eclipseo , thanks for reporting. It appears our internal RISC-V header lacks this error/requirement, that's surprising. I've pinged the LLVM issue. In the meantime, let's default runtime dispatch to disabled on RISC-V and allow override. |
copybara-service bot
pushed a commit
that referenced
this issue
Jun 3, 2024
Public Clang <= 18 still appears to require compiler flags for RVV. Also split HWY_HAVE_RUNTIME_DISPATCH into multiple macros to enable overriding parts of the logic. PiperOrigin-RevId: 639667053
copybara-service bot
pushed a commit
that referenced
this issue
Jun 3, 2024
Public Clang <= 18 still appears to require compiler flags for RVV. Also split HWY_HAVE_RUNTIME_DISPATCH into multiple macros to enable overriding parts of the logic. PiperOrigin-RevId: 639667053
copybara-service bot
pushed a commit
that referenced
this issue
Jun 3, 2024
Public Clang <= 18 still appears to require compiler flags for RVV. Also split HWY_HAVE_RUNTIME_DISPATCH into multiple macros to enable overriding parts of the logic. PiperOrigin-RevId: 639667053
copybara-service bot
pushed a commit
that referenced
this issue
Jun 3, 2024
Public Clang <= 18 still appears to require compiler flags for RVV. GCC 13 also has an #error and 14 is missing mulh/mulhu. Also split HWY_HAVE_RUNTIME_DISPATCH into multiple macros to enable overriding parts of the logic. PiperOrigin-RevId: 639667053
copybara-service bot
pushed a commit
that referenced
this issue
Jun 3, 2024
Public Clang <= 18 still appears to require compiler flags for RVV. GCC 13 also has an #error and 14 is missing mulh/mulhu. Also split HWY_HAVE_RUNTIME_DISPATCH into multiple macros to enable overriding parts of the logic. PiperOrigin-RevId: 639667053
sezero
pushed a commit
to libsdl-org/highway
that referenced
this issue
Jan 6, 2025
Public Clang <= 18 still appears to require compiler flags for RVV. GCC 13 also has an #error and 14 is missing mulh/mulhu. Also split HWY_HAVE_RUNTIME_DISPATCH into multiple macros to enable overriding parts of the logic. PiperOrigin-RevId: 639709709
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello,
The latest Highway 1.2.0, on Fedora Rawhide, riscv arch, Clang 18.1.6:
Apparently this ba6a13d / #2159 was supposed to fix the issue of RISCV without RVV, but it doesn't seem to be working.
The text was updated successfully, but these errors were encountered: