Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add common Cgroup interface #6499

Merged
merged 1 commit into from
Nov 3, 2021
Merged

Conversation

dqminh
Copy link
Contributor

@dqminh dqminh commented Aug 25, 2021

This is part of cgroupv2 patch set. Here we add a Cgroup interface that
both v1 and v2 need to conform to, and port cgroupv1 to use that first.

@google-cla google-cla bot added the cla: yes CLA has been signed label Aug 25, 2021
@dqminh
Copy link
Contributor Author

dqminh commented Aug 25, 2021

cc @avagin @fvoznika

@avagin avagin requested review from fvoznika and avagin August 30, 2021 16:58
@avagin
Copy link
Collaborator

avagin commented Sep 24, 2021

The patch looks good to me. CgroupJSON looks very familiar d85ae50#diff-f552c5573a6d5130b7ba9d96a88bf82fb14a5749ae8f7b2baeffbd56d6dee33eR348.

runsc/cgroup/cgroup.go Outdated Show resolved Hide resolved
@avagin avagin self-assigned this Sep 24, 2021
This is part of cgroupv2 patch set. Here we add a Cgroup interface that
both v1 and v2 need to conform to, and port cgroupv1 to use that first.

Signed-off-by: Daniel Dao <[email protected]>
@google-cla
Copy link

google-cla bot commented Nov 1, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no CLA has not been signed and removed cla: yes CLA has been signed labels Nov 1, 2021
@dqminh
Copy link
Contributor Author

dqminh commented Nov 1, 2021

The patch looks good to me. CgroupJSON looks very familiar d85ae50#diff-f552c5573a6d5130b7ba9d96a88bf82fb14a5749ae8f7b2baeffbd56d6dee33eR348.

Yes ! i thought that i had changed the author to you, but i did not. This was changed now, and rebased on top of latest master.

@dqminh dqminh mentioned this pull request Nov 3, 2021
@avagin avagin self-requested a review November 3, 2021 16:37
@avagin avagin added cla: yes CLA has been signed ready to pull and removed cla: no CLA has not been signed labels Nov 3, 2021
@copybara-service copybara-service bot merged commit 5185548 into google:master Nov 3, 2021
@arno01 arno01 mentioned this pull request Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes CLA has been signed ready to pull
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants