Update containerd dependency to v1.4.9 #6485
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates containerd dependencies to v1.4 with ``` go get github.com/containerd/[email protected] bazel run //:gazelle -- update-repos -from_file=go.mod ```
Commit 453cb28c0b153e756b425ab34f5c2b0e6d57b6f2 update honnef.co/go/tools in WORKSPACE but didn't update it in go.mod, so later attempt to sync using gazelle will revert to older version which doesn't build. This is the result of ``` go get honnef.co/go/[email protected] bazel run //:gazelle -- update-repos -from_file=go.mod ```
|
@fvoznika i think binaries built with containerd 1.4 should still work with 1.3 runtime as containerd protocol has not changed since v1.2, So this change should still work with containerd 1.3. |
|
@dqminh containerd is backwards compatible with older shims, e.g. containerd 1.3 works with shims built with 1.2. However, shims are not guaranteed to be backward compatible with older containerd, e.g. shim built with 1.3 interfacing with containerd 1.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only upgrades the tracked dependencies of containerd to 1.4 from 1.3, tracking in #6232
This doesn't include any code changes in libraries usages or runtimeoptions to try to maintain compat with 1.3 as much as possible. As far as i can see, all containerd tests are passing locally.