cgroup: retry file writes on EINTR errors #3102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adunham-stripe
force-pushed
the
andrew/cgroup-eintr
branch
from
e9fe638 to
e6b9c21
Compare
adunham-stripe
force-pushed
the
andrew/cgroup-eintr
branch
from
e6b9c21 to
079123b
Compare
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 8, 2020
After deploying a version of gvisor built with Go 1.14, we're seeing errors setting up cgroups (we manually run `runsc` via `runsc run`, which creates the cgroup). This turns out to be a known issue with Go: golang/go#38033. Given that the [fix won't be backported](golang/go#39026 (comment)), we should retry writes that may fail with EINTR. This is also what runc does: opencontainers/runc#2258 FUTURE_COPYBARA_INTEGRATE_REVIEW=#3102 from stripe:andrew/cgroup-eintr 079123b PiperOrigin-RevId: 320183771
|
Ping @nlacasse this never got merged. |
zkoopmans
approved these changes
Jul 28, 2020
| // Retry writes on EINTR; see: | ||
| // https://github.com/golang/go/issues/38033 | ||
| for { | ||
| err := ioutil.WriteFile(fullpath, []byte(data), 0700) |
There was a problem hiding this comment.
nit:
if errors.Is(err, syscall.EINTR) {
continue
}
return err
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 28, 2020
After deploying a version of gvisor built with Go 1.14, we're seeing errors setting up cgroups (we manually run `runsc` via `runsc run`, which creates the cgroup). This turns out to be a known issue with Go: golang/go#38033. Given that the [fix won't be backported](golang/go#39026 (comment)), we should retry writes that may fail with EINTR. This is also what runc does: opencontainers/runc#2258 FUTURE_COPYBARA_INTEGRATE_REVIEW=#3102 from stripe:andrew/cgroup-eintr 079123b PiperOrigin-RevId: 323575152
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After deploying a version of gvisor built with Go 1.14, we're seeing errors setting up cgroups (we manually run
runscviarunsc run, which creates the cgroup). This turns out to be a known issue with Go: golang/go#38033. Given that the fix won't be backported, we should retry writes that may fail with EINTR.This is also what runc does: opencontainers/runc#2258