Allow factories to customize their generated Providers #1864
+678
−169
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow factories to customize their generated Providers
This enables a few optimizations
InternalContext
overheads addressing High memory consumption to obtain a Singleton instance via Injector or Provider #1802ConstantBindings
, one time bindings likeInitializable
and@Singleton
bound values, and a number of multibinder bindings in particular.BindingImpl
to share provider instances.The tricky part is about multibindings, which have complex multi-phase initialization semantics, so we need to be defensive about
makeProvider
getting called prior to being initialized. To help manage this ILookupProcessor
to run after multibinders.SyntheticProviderFactory
allocate its delegate lazily.OptionalBinder
explicitly initialize their delegate bindings and also be defensive against recursive and duplicate initialization. This is necessary to force initialization to be correct when ourgetExistingBinding
query ends up delegating to another multibinder.