Bump asm version to 6.2 for JDK 10/11 support #1169

svrakitin · 2018-03-28T20:04:23Z

No description provided.

googlebot · 2018-03-28T20:04:27Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ronshapiro · 2018-03-28T20:11:15Z

Try "I signed it!" - the bot may not be smart enough to detect "we"

googlebot · 2018-04-03T11:48:47Z

CLAs look good, thanks!

svrakitin · 2018-04-04T09:33:15Z

Is there anything I can do to speed up the process of getting this to master? ;)

mkurz · 2018-04-10T09:13:44Z

Getting this merged would be really really great! 👍

sameb · 2018-04-10T14:51:15Z

this looks reasonable, but can someone please clarify what about JDK10 fails w/ guice? also, can someone update the travis config to run over jdk10 too?

@netdpb i think the preferred way to do PRs now is to submit them internally w/ MOE (which i think has a way to pull in PRs and retain the author metadata?) and then push it back out. @ronshapiro might know.

svrakitin · 2018-04-10T15:08:52Z

@sameb asm's ClassReader will simply fail to read .class files with bytecode of 54.0 version.

Travis doesn't have oraclejdk10 and openjdk10 targets yet. ;(

svrakitin · 2018-04-18T09:51:17Z

Any update on this?

mkurz · 2018-05-30T09:42:36Z

FYI: ASM 6.2 released with better JDK 10 support and even with JDK 11 support already!
http://asm.ow2.io/versions.html
https://gitlab.ow2.org/asm/asm/tags
https://gitlab.ow2.org/asm/asm/issues/317830

eximius313 · 2018-06-02T13:01:36Z

+1 for ASM 6.2

pettyjamesm · 2018-06-05T23:47:20Z

Any update on the timeline for this to make it into a release? Would be great to be able to use guice on newer JVMs.

ronshapiro · 2018-06-06T14:00:35Z

We have run into a bumps in the road in upgrading this, but we are working on resolving them

ronshapiro · 2018-06-06T14:01:41Z

Would it make sense to recommend that users bring their own copy of ASM if they care about the Java version they want to support? Is this simply just adding a different version of the library on the classpath?

mkurz · 2018-06-06T14:04:28Z

Is there a actually a reason why Guice bundles asm in the final package? Why not keep it as normal dependency so users can just override it?

sameb · 2018-06-06T14:46:33Z

I believe the historical reason was the ASM did not guarantee compatibility between releases, so shading it was effectively required. I think as the past few ASM releases, that's not true anymore... so perhaps we can stop shading asm?

…

On Wed, Jun 6, 2018 at 10:04 AM Matthias Kurz ***@***.***> wrote: Is there a actually a reason why Guice bundles the asm in the final package? Why not keep it as normal dependency so users can just override it? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1169 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACC7Eu-NYbalDW3towa0_uAWxVY0Tx2Eks5t5-FxgaJpZM4S_RsH> .

mcculls · 2018-06-06T14:52:34Z

Note that the build already produces a version of Guice that doesn't bundle asm or cglib:

http://repo1.maven.org/maven2/com/google/inject/guice/4.2.0/guice-4.2.0-classes.jar

This is a jar of the Guice classes before any JarJar'ing.

Also if you don't need AOP then there's the "no_aop" jar which doesn't use asm/cglib at all:

http://repo1.maven.org/maven2/com/google/inject/guice/4.2.0/guice-4.2.0-no_aop.jar

prodsey · 2018-06-08T18:08:42Z

This is great.
We are planning to migrate an enterprise project (extensively uses guice ) from JDK 9 to JDK 10
Any ballpark ETA on this change to support JDK 10?
Thanks

prodsey · 2018-06-26T10:05:13Z

Any update on when can we expect jdk 10, 11 supported release?

prodsey · 2018-06-28T19:14:21Z

Below exception on startup with 4.2 release + JDK 10
I am thinking this is related?

Any update on the release?

Caused by: java.lang.IllegalArgumentException
at com.google.inject.internal.asm.$ClassReader.(ClassReader.java:160)
at com.google.inject.internal.asm.$ClassReader.(ClassReader.java:143)
at com.google.inject.internal.asm.$ClassReader.(ClassReader.java:418)
at com.google.inject.internal.cglib.proxy.$BridgeMethodResolver.resolveAll(BridgeMethodResolver.java:69)
at com.google.inject.internal.cglib.proxy.$Enhancer.emitMethods(Enhancer.java:1132)
at com.google.inject.internal.cglib.proxy.$Enhancer.generateClass(Enhancer.java:630)
at com.google.inject.internal.cglib.core.$DefaultGeneratorStrategy.generate(DefaultGeneratorStrategy.java:25)
at com.google.inject.internal.cglib.core.$AbstractClassGenerator.generate(AbstractClassGenerator.java:329)

svrakitin · 2018-06-28T19:19:14Z

@prodsey this is original issue :)

prodsey · 2018-06-28T22:05:35Z

thanks @svrakitin

any ETA on when this will be released?

I tried with
[classifier]no_aop[/classifier] and additionally including ASM 6.2 and cglib 3.2.6 (did not work)

any other way I can start testing with JDK 10?

himanshukandwal · 2018-06-29T20:38:33Z

Facing the same issue after applying the suggested fixes.

Caused by: java.lang.IllegalArgumentException
at [email protected]/com.google.inject.internal.asm.$ClassReader.(ClassReader.java:160)
at [email protected]/com.google.inject.internal.asm.$ClassReader.(ClassReader.java:143)
at [email protected]/com.google.inject.internal.asm.$ClassReader.(ClassReader.java:418)
at [email protected]/com.google.inject.internal.util.LineNumbers.(LineNumbers.java:64)
at [email protected]/com.google.inject.internal.util.StackTraceElements$1.load(StackTraceElements.java:49)
at [email protected]/com.google.inject.internal.util.StackTraceElements$1.load(StackTraceElements.java:45)
at [email protected]/com.google.common.cache.LocalCache$LoadingValueReference.loadFuture(LocalCache.java:3443)
at [email protected]/com.google.common.cache.LocalCache$Segment.loadSync(LocalCache.java:2169)
at [email protected]/com.google.common.cache.LocalCache$Segment.lockedGetOrLoad(LocalCache.java:2128)
at [email protected]/com.google.common.cache.LocalCache$Segment.get(LocalCache.java:2041)

mcculls · 2018-06-29T21:37:37Z

@prodsey what was the error you had with the 'no_aop' jar? That doesn't use ASM or CGLIB at all, but at the same time you won't have access to any AOP features such as method interception. If you're still seeing ASM related errors with the 'no_aop' jar then check your classpath in case it contains another version of Guice.

If you want to try Guice with AOP and a different version of ASM/CGLIB then you should take the [classifier]classes[/classifier] jar and add ASM 6.2 and CGLIB 3.2.6 as separate dependencies. Again making sure the original Guice jar isn't being dragged onto the same project classpath.

( of course an official release with this version bump would also be appreciated! )

prodsey · 2018-06-29T23:31:57Z

@mcculls
With no_aop and asm 6.2 + latest cglib I got the same exception .... checked dep hierarchy and removed all older versions of guice. But still got the same exception. I need method interceptors. I have not tried [classifier]classes[/classifier] . Should that work?

I do not see [classifier]classes[/classifier] option in below link
https://github.com/google/guice/wiki/Guice42

I agree, an official release with JDK 10,11 support will definitely help.

@sameb
Can you please throw some light on when can we expect an official release?

prodsey · 2018-06-30T16:53:11Z

@mcculls
Thank you for the input. [classifier]classes[/classifier] Works fine when you include asm 6.2 and cglib JARs. I did some basic testing with OpenJDK 10.0.1.

I guess this is a good option till the official release right? Do you see any downside?

googlebot added the cla: no label Mar 28, 2018

googlebot added cla: yes and removed cla: no labels Apr 3, 2018

netdpb requested a review from sameb April 10, 2018 14:14

svrakitin mentioned this pull request May 8, 2018

Regular releases supporting new Java versions #1181

Closed

Bump asm version to 6.2 for JDK 10/11 support

0f26658

svrakitin changed the title ~~Bumped asm version to 6.1.1 for JDK 10 support~~ Bump asm version to 6.2 for JDK 10/11 support May 30, 2018

mkurz mentioned this pull request Jun 2, 2018

Exceptions during initialization of ApplicationModule are hidden in JDK10 playframework/playframework#8454

Closed

Add oraclejdk10 and oraclejdk11 to the Travis build matrix

2a7cd72

michelemauro mentioned this pull request Jul 3, 2018

upgrade to java 10 #1195

Closed

steinybot mentioned this pull request Jul 10, 2018

Support for Java 10 lagom/lagom#1276

Closed

ronshapiro mentioned this pull request Jul 13, 2018

Moe Sync #1197

Merged

ronshapiro closed this in #1197 Jul 13, 2018

ronshapiro mentioned this pull request Jul 13, 2018

Stop shading ASM? #1198

Closed

svrakitin deleted the jdk10-support branch July 23, 2018 13:54

davido mentioned this pull request Aug 23, 2018

Gerrit fails on Bazel@HEAD on JDK10 bazelbuild/bazel#5967

Closed

mkurz mentioned this pull request Sep 1, 2018

Jdk11 compatibility #1203

Closed

davido mentioned this pull request Sep 12, 2018

Set up CI job for Gerrit on Java 10 bazelbuild/continuous-integration#325

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump asm version to 6.2 for JDK 10/11 support #1169

Bump asm version to 6.2 for JDK 10/11 support #1169

svrakitin commented Mar 28, 2018

googlebot commented Mar 28, 2018

ronshapiro commented Mar 28, 2018

googlebot commented Apr 3, 2018

svrakitin commented Apr 4, 2018

mkurz commented Apr 10, 2018

sameb commented Apr 10, 2018

svrakitin commented Apr 10, 2018 •

edited

Loading

svrakitin commented Apr 18, 2018

mkurz commented May 30, 2018

eximius313 commented Jun 2, 2018

pettyjamesm commented Jun 5, 2018

ronshapiro commented Jun 6, 2018

ronshapiro commented Jun 6, 2018

mkurz commented Jun 6, 2018 •

edited

Loading

sameb commented Jun 6, 2018 via email

mcculls commented Jun 6, 2018

prodsey commented Jun 8, 2018

prodsey commented Jun 26, 2018

prodsey commented Jun 28, 2018

svrakitin commented Jun 28, 2018

prodsey commented Jun 28, 2018 •

edited

Loading

himanshukandwal commented Jun 29, 2018

mcculls commented Jun 29, 2018

prodsey commented Jun 29, 2018 •

edited

Loading

prodsey commented Jun 30, 2018 •

edited

Loading

Bump asm version to 6.2 for JDK 10/11 support #1169

Bump asm version to 6.2 for JDK 10/11 support #1169

Conversation

svrakitin commented Mar 28, 2018

googlebot commented Mar 28, 2018

What to do if you already signed the CLA

Individual signers

Corporate signers

ronshapiro commented Mar 28, 2018

googlebot commented Apr 3, 2018

svrakitin commented Apr 4, 2018

mkurz commented Apr 10, 2018

sameb commented Apr 10, 2018

svrakitin commented Apr 10, 2018 • edited Loading

svrakitin commented Apr 18, 2018

mkurz commented May 30, 2018

eximius313 commented Jun 2, 2018

pettyjamesm commented Jun 5, 2018

ronshapiro commented Jun 6, 2018

ronshapiro commented Jun 6, 2018

mkurz commented Jun 6, 2018 • edited Loading

sameb commented Jun 6, 2018 via email

mcculls commented Jun 6, 2018

prodsey commented Jun 8, 2018

prodsey commented Jun 26, 2018

prodsey commented Jun 28, 2018

svrakitin commented Jun 28, 2018

prodsey commented Jun 28, 2018 • edited Loading

himanshukandwal commented Jun 29, 2018

mcculls commented Jun 29, 2018

prodsey commented Jun 29, 2018 • edited Loading

prodsey commented Jun 30, 2018 • edited Loading

svrakitin commented Apr 10, 2018 •

edited

Loading

mkurz commented Jun 6, 2018 •

edited

Loading

prodsey commented Jun 28, 2018 •

edited

Loading

prodsey commented Jun 29, 2018 •

edited

Loading

prodsey commented Jun 30, 2018 •

edited

Loading