Deprecate pattern-related methods in Predicates. There is a better alternative since JDK 1.8. #6483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
…ternative since JDK 1.8. RELNOTES=n/a PiperOrigin-RevId: 531052335
Stephan202
added a commit
to PicnicSupermarket/error-prone-support
that referenced
this pull request
May 11, 2023
Stephan202
added a commit
to PicnicSupermarket/error-prone-support
that referenced
this pull request
May 11, 2023
While there, configure `StaticImport` to not require static importing of `com.google.common.base.Predicates.contains`. See google/guava#6483.
Stephan202
reviewed
May 11, 2023
Comment on lines
+237
to
244
| * @deprecated Use {@link java.util.regex.Pattern#asPredicate} | ||
| */ | ||
| @J2ktIncompatible | ||
| @GwtIncompatible // Only used by other GWT-incompatible code. | ||
| @Deprecated | ||
| public static Predicate<CharSequence> containsPattern(String pattern) { | ||
| return new ContainsPatternFromStringPredicate(pattern); | ||
| } |
There was a problem hiding this comment.
CC @cushon: Error Prone CompilationTestHelper and DiagnosticTestHelper users are nudged to using this API, and because expectErrorMessage expects a com.google.common.base.Predicate rather than a java.util.function.Predicate, the suggested alternative won't readily work. (The workaround is to use s -> Pattern.compile(pattern).find(s), though that doesn't make for as nice an API. 🤔)
There was a problem hiding this comment.
Good call, I will look at updating those APIs
copybara-service bot
pushed a commit
to google/error-prone
that referenced
this pull request
May 11, 2023
google/guava#6483 (comment) PiperOrigin-RevId: 531307672
copybara-service bot
pushed a commit
to google/error-prone
that referenced
this pull request
May 12, 2023
…va.util.function.Predicate`s google/guava#6483 (comment) PiperOrigin-RevId: 531307672
copybara-service bot
pushed a commit
to google/error-prone
that referenced
this pull request
May 13, 2023
…va.util.function.Predicate`s google/guava#6483 (comment) Startblock: * unknown commit is submitted PiperOrigin-RevId: 531307672
copybara-service bot
pushed a commit
to google/error-prone
that referenced
this pull request
May 13, 2023
…va.util.function.Predicate`s google/guava#6483 (comment) Startblock: * unknown commit is submitted PiperOrigin-RevId: 531307672
copybara-service bot
pushed a commit
to google/error-prone
that referenced
this pull request
May 13, 2023
…va.util.function.Predicate`s google/guava#6483 (comment) Startblock: * unknown commit is submitted PiperOrigin-RevId: 531307672
copybara-service bot
pushed a commit
to google/error-prone
that referenced
this pull request
May 15, 2023
…va.util.function.Predicate`s google/guava#6483 (comment) Startblock: * unknown commit is submitted PiperOrigin-RevId: 531307672
copybara-service bot
pushed a commit
to google/error-prone
that referenced
this pull request
May 15, 2023
…va.util.function.Predicate`s google/guava#6483 (comment) Startblock: * unknown commit is submitted PiperOrigin-RevId: 532114794
Stephan202
added a commit
to PicnicSupermarket/error-prone-support
that referenced
this pull request
Aug 29, 2023
While there, configure `StaticImport` to not require static importing of `com.google.common.base.Predicates.contains`. See google/guava#6483.
Stephan202
added a commit
to PicnicSupermarket/error-prone-support
that referenced
this pull request
Aug 30, 2023
While there, configure `StaticImport` to not require static importing of `com.google.common.base.Predicates.contains`. The new rules triggered cleanup of some `CompilationTestHelper` usages. See google/guava#6483.
rickie
pushed a commit
to PicnicSupermarket/error-prone-support
that referenced
this pull request
Sep 1, 2023
While there, configure `StaticImport` to not require static importing of `com.google.common.base.Predicates.contains`. The new rules triggered cleanup of some `CompilationTestHelper` usages. See google/guava#6483.
Stephan202
added a commit
to PicnicSupermarket/error-prone-support
that referenced
this pull request
Oct 9, 2023
While there, configure `StaticImport` to not require static importing of `com.google.common.base.Predicates.contains`. The new rules triggered cleanup of some `CompilationTestHelper` usages. See google/guava#6483.
rickie
pushed a commit
to PicnicSupermarket/error-prone-support
that referenced
this pull request
Oct 10, 2023
While there, configure `StaticImport` to not require static importing of `com.google.common.base.Predicates.contains`. The new rules triggered cleanup of some `CompilationTestHelper` usages. See google/guava#6483.
rickie
pushed a commit
to PicnicSupermarket/error-prone-support
that referenced
this pull request
Oct 10, 2023
While there, configure `StaticImport` to not require static importing of `com.google.common.base.Predicates.contains`. The new rules triggered cleanup of some `CompilationTestHelper` usages. See google/guava#6483.
rickie
pushed a commit
to PicnicSupermarket/error-prone-support
that referenced
this pull request
Oct 11, 2023
While there, configure `StaticImport` to not require static importing of `com.google.common.base.Predicates.contains`. The new rules triggered cleanup of some `CompilationTestHelper` usages. See google/guava#6483.
rickie
pushed a commit
to PicnicSupermarket/error-prone-support
that referenced
this pull request
Oct 11, 2023
While there, configure `StaticImport` to not require static importing of `com.google.common.base.Predicates.contains`. The new rules triggered cleanup of some `CompilationTestHelper` usages. See google/guava#6483.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate pattern-related methods in Predicates. There is a better alternative since JDK 1.8.
RELNOTES=n/a