Document ForwardingExecutorService behavior for default methods #6299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, Guava is built with Java 9 and `ExecutorService` has no default methods. This changes in Java 19, where `ExecutorService.close` is added. Ensure users have right expectations about future evolution of the `ForwardingExecutorService` and its compatibility with newer Java versions.
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 18, 2023
Currently, Guava is built with Java 9 and `ExecutorService` has no default methods. This changes in Java 19, where `ExecutorService.close` is added. Ensure users have right expectations about future evolution of the `ForwardingExecutorService` and its compatibility with newer Java versions. Fixes #6296 Fixes #6299 RELNOTES=n/a PiperOrigin-RevId: 502827344
findepi
deleted the
findepi/document-forwardingexecutorservice-behavior-for-default-methods-3b0318
branch
|
Thanks @cpovirk for adding the note to other classes, and for the merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Guava is built with Java 9 and
ExecutorServicehas no default methods. This changes in Java 19, whereExecutorService.closeis added. Ensure users have right expectations about future evolution of theForwardingExecutorServiceand its compatibility with newer Java versions.Fixes #6296