Assorted improvements to nullness annotations. #5918
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_421129392
branch
from
0b32433 to
3e71023
Compare
I don't think any of the Guava changes are user-visible. Details: - Many of these fix bugs that will be noticed by the forthcoming version of our hacky internal nullness checker. - Some of these fix bugs that even the forthcoming version won't notice but that I happened to see. - Some changes add `@Nullable` to return types of methods that always throw an exception. There's no strict need for this, but we've mostly done it otherwise, so I figured I'd be consistent (and quiet `ReturnMissingNullable`, at least until I quiet it for all such methods with google/error-prone#2910). - The `NullnessCasts` change is to discourage `ReturnMissingNullable` from adding a `@Nullable` annotation where we don't want it. (But we'll probably never run `ReturnMissingNullable` in the "aggressive" mode over this code, anyway, so there's not likely to be a need for the suppression.) - The `@ParametricNullness` changes evidently aren't necessary for anyone right now, but they could theoretically be necessary for j2objc users until j2objc further enhances its support for nullness annotations. - The `AbstractFuture` change removes a suppression that would be necessary under the Checker Framework (which would consider the supermethod's return type to be non-nullable) but isn't necessary for us (because we consider the supermethod's return type to have unspecified nullness). RELNOTES=n/a PiperOrigin-RevId: 421129392
copybara-service
bot
force-pushed
the
test_421129392
branch
from
3e71023 to
32391ae
Compare
copybara-service
bot
force-pushed
the
test_421129392
branch
from
32391ae to
f881fab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assorted improvements to nullness annotations.
I don't think any of the Guava changes are user-visible.
Details:
@Nullableto return types of methods that always throw an exception. There's no strict need for this, but we've mostly done it otherwise, so I figured I'd be consistent (and quietReturnMissingNullable, at least until I quiet it for all such methods with ReturnMissingNullable should ignore @DoNotCall and always throwing methods error-prone#2910).NullnessCastschange is to discourageReturnMissingNullablefrom adding a@Nullableannotation where we don't want it. (But we'll probably never runReturnMissingNullablein the "aggressive" mode over this code, anyway, so there's not likely to be a need for the suppression.)@ParametricNullnesschanges evidently aren't necessary for anyone right now, but they could theoretically be necessary for j2objc users until j2objc further enhances its support for nullness annotations.AbstractFuturechange removes a suppression that would be necessary under the Checker Framework (which would consider the supermethod's return type to be non-nullable) but isn't necessary for us (because we consider the supermethod's return type to have unspecified nullness).RELNOTES=n/a