-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some annotations from "On Leveraging Tests to Infer Nullable Annotations" data #6510
Labels
Comments
copybara-service bot
pushed a commit
that referenced
this issue
Jul 7, 2023
…(if possibly less convenient) original version, updating Guava. This is another annotation from the [On Leveraging Tests to Infer Nullable Annotations](#6510) data. RELNOTES=n/a PiperOrigin-RevId: 545778930
copybara-service bot
pushed a commit
to google/xplat
that referenced
this issue
Jul 7, 2023
…(if possibly less convenient) original version, updating Guava. This is another annotation from the [On Leveraging Tests to Infer Nullable Annotations](google/guava#6510) data. PiperOrigin-RevId: 546272042
copybara-service bot
pushed a commit
that referenced
this issue
Jul 7, 2023
…(if possibly less convenient) original version, updating Guava. This is another annotation from the [On Leveraging Tests to Infer Nullable Annotations](#6510) data. RELNOTES=n/a PiperOrigin-RevId: 546272042
copybara-service bot
pushed a commit
that referenced
this issue
Aug 24, 2023
The Guava changes include further annotations [from "On Leveraging Tests to Infer Nullable Annotations."](#6510) RELNOTES=n/a PiperOrigin-RevId: 559416747
copybara-service bot
pushed a commit
to google/xplat
that referenced
this issue
Aug 24, 2023
The Guava changes include further annotations [from "On Leveraging Tests to Infer Nullable Annotations."](google/guava#6510) PiperOrigin-RevId: 559605577
copybara-service bot
pushed a commit
that referenced
this issue
Aug 24, 2023
The Guava changes include further annotations [from "On Leveraging Tests to Infer Nullable Annotations."](#6510) RELNOTES=n/a PiperOrigin-RevId: 559605577
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
After a conversation with @jensdietrich in an Error Prone issue, Jens provided us with some data on Guava fields, parameters, and method returns that see null values during the course of testing (aside from tests that are checking that NPE occurs :)). That comes from the paper in the title:
I've looked at the data for a few classes already and submitted some changes:
ClassToInstanceMap
andTypeToInstanceMap
had previously had non-nullable types because we were limiting which annotations we used.MapMakerInternalMap
was missing many annotations (and is very likely still be missing a few) because we hadn't tried to annotate it.MoreObjects.firstNonNull
was missing a nullness annotation, and the data did not show that because it turned out that we'd never tested the case or even open-sourced the tests that we did have.I may try to incorporate some more annotations in the future, but that's the story so far.
The text was updated successfully, but these errors were encountered: