This repository has been archived by the owner on Jan 18, 2022. It is now read-only.
Overdue cleanup #69
Merged
Overdue cleanup #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add a Deps directory to pull in the SessionFetcher via a submodule. - Add workspaces to GTMOAuth2Sample and GTMOAuth2SampleTouch that build the fetcher framework targets. - Support framework-style includes in GTMOAuth2Authentication.h by setting a build flag.
In the GTM OAuth2 Mac window controller, defer the stopLoading: message so it's not sent during the WebView webView:resource:willSendRequest: delegate method invocation. This fixes a crash that was reproducible when signing in with DailyMotion. It does not occur on iOS (as iOS isn't invoking stopLoading on the webview.) Similar crashes have been reported in GTMOAuth1 on iOS and OS X: #66 https://groups.google.com/forum/#!searchin/gtm-oauth/stopLoading/gtm-oauth/N6jlOpL9k5g/BXFnNEIudb0J Also make a few unintentionally global variables static.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.