Enable additional Error Prone checks & fix violations #2561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of them also enforce additional Google Java Format requirements which are not handled by google-java-format, such as disallowing wildcard imports. Not all experimental checks have been listed because some are not applicable, such as Dependency Injection framework checks, or checks related to Guava's immutable collections (since Gson's main code does not have a dependency on Guava). Other checks have been omitted because they are probably not relevant (this was a subjective choice), or would require larger refactoring or would flag issues with the public API, which cannot be changed easily.
Marcono1234
commented
Dec 2, 2023
gson/src/main/java/com/google/gson/internal/JsonReaderInternalAccess.java
Show resolved
Hide resolved
Comment on lines
-214
to
-215
| default: | ||
| throw new IllegalArgumentException("Unexpected token" + reader.peek()); |
There was a problem hiding this comment.
switch covers all enum constants (this redundant default was flagged by Error Prone).
9 tasks
eamonnmcmanus
requested changes
Dec 3, 2023
gson/src/main/java/com/google/gson/internal/JsonReaderInternalAccess.java
Show resolved
Hide resolved
gson/src/test/java/com/google/gson/functional/CustomTypeAdaptersTest.java
Outdated
Show resolved
Hide resolved
Marcono1234
commented
Dec 10, 2023
Comment on lines
-265
to
-266
| try { | ||
| // Invoke the ProtoClass.newBuilder() method |
There was a problem hiding this comment.
This is related to #2561 (comment).
I removed the inner try-catch because there is already an enclosing catch (Exception e) which wraps the exception in a JsonParseException, so this would probably have lead to JsonParseException -> JsonParseException -> actual exception.
(Compare this with whitespace diff turned off to properly see the changes.)
eamonnmcmanus
approved these changes
Jan 9, 2024
gson/src/main/java/com/google/gson/internal/NonNullElementWrapperList.java
Show resolved
Hide resolved
tibor-universe
pushed a commit
to getuniverse/gson
that referenced
this pull request
Sep 14, 2024
* Enable additional Error Prone checks & fix violations Some of them also enforce additional Google Java Format requirements which are not handled by google-java-format, such as disallowing wildcard imports. Not all experimental checks have been listed because some are not applicable, such as Dependency Injection framework checks, or checks related to Guava's immutable collections (since Gson's main code does not have a dependency on Guava). Other checks have been omitted because they are probably not relevant (this was a subjective choice), or would require larger refactoring or would flag issues with the public API, which cannot be changed easily. * Address review feedback --------- Co-authored-by: Éamonn McManus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Enable additional Error Prone checks which are disabled by default
Description
Some of them also enforce additional Google Java Format requirements which are not handled by google-java-format, such as disallowing wildcard imports.
Not all experimental checks have been listed because some are not applicable, such as Dependency Injection framework checks, or checks related to Guava's immutable collections (since Gson's main code does not have a dependency on Guava).
Other checks have been omitted because they are probably not relevant (this was a subjective choice), or would require larger refactoring or would flag issues with the public API, which cannot be changed easily.
Open questions:
Though might not be easily possible without separate
testCompileconfiguration, which duplicates configuration, or without disabling all Error Prone checks for a certain file path. There are also the (undocumented?) flags-XepCompilingTestOnlyCodeand-XepCompilingPubliclyVisibleCode, but it is not clear which checks consider them, and it would probably still be necessary to have a separatetestCompileconfiguration then which sets these flags.Checklist
This is automatically checked by
mvn verify, but can also be checked on its own usingmvn spotless:check.Style violations can be fixed using
mvn spotless:apply; this can be done in a separate commit to verify that it did not cause undesired changes.null@since $next-version$(
$next-version$is a special placeholder which is automatically replaced during release)TestCase)mvn clean verify javadoc:jarpasses without errors