-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CodeQL GitHub code scanning workflow #2076
Merged
eamonnmcmanus
merged 5 commits into
google:master
from
Marcono1234:marcono1234/code-scanning
Feb 18, 2022
Merged
Add CodeQL GitHub code scanning workflow #2076
eamonnmcmanus
merged 5 commits into
google:master
from
Marcono1234:marcono1234/code-scanning
Feb 18, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`annotations.proto` also seems to be only relevant for tests because the test explicitly registers them as extensions. By default the Proto adapter does not consider them.
Marcono1234
force-pushed
the
marcono1234/code-scanning
branch
from
February 12, 2022 23:42
2b2d8d4
to
a29ad1e
Compare
Marcono1234
force-pushed
the
marcono1234/code-scanning
branch
from
February 16, 2022 20:01
f51f169
to
7337057
Compare
Were you planning to fix the remaining CodeQL failures? |
I think all remaining findings are false positives, or can be ignored (for now):
You as maintainer can dismiss the false positive alerts later on, if you like. |
Thanks, I've dismissed the three remaining errors. I think this will be helpful! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a GitHub code scanning workflow running CodeQL, see GitHub documentation "About code scanning with CodeQL".
The workflow is currently configured to run all queries in the "security-and-quality" suite; this is more than the default which only runs certain security queries. I have fixed some of the findings; it looks like all other ones are false positives, or can be ignored.
It appears by default generated and test code is scanned as well (and cannot be excluded?), but results for it can be filtered in the security view.Edit: Have changed the build command to
mvn compile
; therefore test code is not analyzed anymore.I have marked this pull request as draft for now to get some feedback. No worries in case you don't want to include this.