Formalize null handling of type tokens #2030
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| new Gson().getAdapter((TypeToken<Object>) null); | ||
| assertTrue("Unreachable", false); | ||
| } | ||
| catch (NullPointerException e) { |
There was a problem hiding this comment.
Can you join this to the previous line?
} catch (NullPointerException e) {
| // Note: ExpectedException cannot be used due to test suite extending TestCase | ||
| try { | ||
| new Gson().getAdapter((TypeToken<Object>) null); | ||
| assertTrue("Unreachable", false); |
There was a problem hiding this comment.
Just fail() would be fine here.
Marcono1234
reviewed
Dec 4, 2021
Comment on lines
+30
to
+32
| import org.junit.Rule; | ||
| import org.junit.Test; | ||
| import org.junit.rules.ExpectedException; |
There was a problem hiding this comment.
These imports seem to be unused.
| @@ -82,4 +86,16 @@ public void testClonedTypeAdapterFactoryListsAreIndependent() { | |||
| } | |||
| @Override public Object read(JsonReader in) throws IOException { return null; } | |||
| } | |||
|
|
|||
| public void testNullAdapterLookup() { | |||
| // Formalize the handling of null type tokens (previously it was partially handled, but still throwing an error) | |||
There was a problem hiding this comment.
Not sure if this comment line here is useful in the test code. To me this message only seems to be relevant regarding why this pull request or commit was created, but not why this test exists.
Note that unlike eamonnmcmanus, I am not a member of this project. Feel free to consider my comments only as suggestion.
|
I am closing this pull request because this issue has been fixed as part of #2153. Thanks nonetheless for your pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1831