Fix warnings #2014
Merged
Fix warnings #2014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marcono1234
commented
Nov 6, 2021
| @@ -35,7 +35,6 @@ | |||
| <groupId>org.apache.maven.plugins</groupId> | |||
| <artifactId>maven-javadoc-plugin</artifactId> | |||
| <configuration> | |||
| <includePackageNames>com.google.gson</includePackageNames> | |||
There was a problem hiding this comment.
Was detected by Eclipse; the maven-javadoc-plugin does not have a parameter with this name (anymore?).
Marcono1234
force-pushed
the
marcono1234/warning-fixes
branch
from
0823478 to
13a58bf
Compare
eamonnmcmanus
requested changes
Nov 6, 2021
| @@ -26,8 +26,8 @@ | |||
| * @author Joel Leitch | |||
| */ | |||
| public class InnerClassExclusionStrategyTest extends TestCase { | |||
| public InnerClass innerClass = new InnerClass(); | |||
There was a problem hiding this comment.
I'm not sure this change is great. Previously the test showed that this field was excluded, despite being public. Now it's still excluded, but maybe that's because the field is private. It might be better to add comments saying why the fields are public.
There was a problem hiding this comment.
Good point! I have reverted the changes for this test class.
eamonnmcmanus
approved these changes
Nov 7, 2021
tibor-universe
pushed a commit
to getuniverse/gson
that referenced
this pull request
Nov 21, 2021
* Fix warnings * Address review feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: The visibility changes in the test classes are not strictly necessary. Eclipse IDE complained that the exposed types had lower visibility than the exposing field.