Using activeSurveyFlow to make flow async

[anandwana001]

Fixes #2815

@shobhitagarwal1612 PTAL?

[codecov]

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 61.72%. Comparing base (9ab91bc) to head (222adf4).

Files with missing lines	Patch %	Lines
...round/ui/datacollection/DataCollectionViewModel.kt	85.71%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #2890      +/-   ##
============================================
+ Coverage     61.68%   61.72%   +0.04%     
  Complexity     1173     1173              
============================================
  Files           268      268              
  Lines          6344     6349       +5     
  Branches        876      875       -1     
============================================
+ Hits           3913     3919       +6     
  Misses         1890     1890              
+ Partials        541      540       -1     

Files with missing lines	Coverage Δ
...round/ui/datacollection/DataCollectionViewModel.kt	72.77% <85.71%> (+1.19%)	⬆️

[shobhitagarwal1612]

Won't this change now start failing to get the job as null?

[anandwana001]

Won't this change now start failing to get the job as survey is null?

Should we make the job as a flow too?

[shobhitagarwal1612]

The question remains the same, will that pass on the error to the next item or will it stabilize the screen when survey is null?

[anandwana001]

The question remains the same, will that pass on the error to the next item or will it stabilize the screen when survey is null?

as the data collection screen is completely dependent on the activeSurvey, so in the worst case should we navigateUp or should we show some loading retry to fix the state flows and get the updated data?

[shobhitagarwal1612]

should we show some loading retry to fix the state flows and get the updated data?

We shouldn't navigate up unless it's the last resort. Given that we know the survey id, we should try to make our sync code async and wait until it is ready.

[gino-m]

Isn't activeSurvey as you're defining it here functionally equivalent to surveyRepository.activeSurveyFlow? If so, why not just expose that instead?

[gino-m]

Did you mean for this to be make public? I don't see a use anywhere else.

[gino-m]

Calling .value here will grab a snapshot of the current survey at the time this VM is initialized. How is that different from what we're doing already?