Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Code health] Replace mock with actual implementation in DataCollectionFragmentTest #2886

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

shobhitagarwal1612
Copy link
Member

@shobhitagarwal1612 shobhitagarwal1612 commented Dec 1, 2024

Towards #2134
Towards #2840

Replaces mock implementation of SubmissionRepository with actual implementation in DataCollectionFragmentTest.

This improves the test coverage for SubmissionRepository by 60% and overall coverage by 1%.

Since this is a test-only change, so end-user behavior remains no-op.

@gino-m @anandwana001 PTAL?

@shobhitagarwal1612 shobhitagarwal1612 requested review from gino-m and removed request for scolsen December 1, 2024 10:13
Copy link

codecov bot commented Dec 1, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 62.68%. Comparing base (9625c2e) to head (b007e4d).

Files with missing lines Patch % Lines
...rsistence/local/room/stores/RoomSubmissionStore.kt 25.00% 3 Missing ⚠️
...ogle/android/ground/ui/home/HomeScreenViewModel.kt 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2886      +/-   ##
============================================
+ Coverage     61.61%   62.68%   +1.06%     
- Complexity     1183     1213      +30     
============================================
  Files           267      267              
  Lines          6362     6364       +2     
  Branches        880      880              
============================================
+ Hits           3920     3989      +69     
+ Misses         1903     1832      -71     
- Partials        539      543       +4     
Files with missing lines Coverage Δ
.../android/ground/repository/SubmissionRepository.kt 80.00% <100.00%> (+61.39%) ⬆️
...ogle/android/ground/ui/home/HomeScreenViewModel.kt 80.35% <50.00%> (-0.35%) ⬇️
...rsistence/local/room/stores/RoomSubmissionStore.kt 68.31% <25.00%> (+9.31%) ⬆️

... and 8 files with indirect coverage changes

@shobhitagarwal1612 shobhitagarwal1612 changed the title [Test Coverage] Replace mock with actual implementation in DataCollectionFragmentTest [Code health] Replace mock with actual implementation in DataCollectionFragmentTest Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants