Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use /// doc-comments instead of /** */ #102

Closed
seaneagan opened this issue Feb 26, 2015 · 2 comments
Closed

Use /// doc-comments instead of /** */ #102

seaneagan opened this issue Feb 26, 2015 · 2 comments

Comments

@seaneagan
Copy link
Contributor

Can either do this manually, or wait until the linter supports it.
@devoncarew
Copy link
Contributor

I'm old school in that I prefer /** ... */, but if much of the code is using /// then consistency is more important -

@devoncarew
Copy link
Contributor

Closing - I think the resolution is to convert over as files are edited -

@seaneagan seaneagan mentioned this issue Mar 18, 2015
Merged
jcollins-g pushed a commit to jcollins-g/grinder.dart that referenced this issue Feb 12, 2021
@munificent
Generate correct intermediate indentation levels. Fixes google#102.
cabb245 
If the expression nesting level jumps from, say, 3 to 6, it needs to consider all possible indentation permutations:

3:6
3:4:6
3:5:6
3:4:5:6

Before this fix, though, it would incorrectly do every subset starting at *zero*, not the minimum leading to tons of extra subsets to consider.

On my machine, this takes formatting dart2js from ~5s to 2.889s.

BUG=dart-lang/dart_style#102
[email protected]

Review URL: https://chromiumcodereview.appspot.com//814913003
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@seaneagan @devoncarew