Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve version handling for eclipse plugin #635

Closed
wants to merge 1 commit into from

Conversation

cristatus
Copy link
Contributor

Use same versions for plugin as google-java-format and
strip versions from copied jar to avoid updating build.properties
and MANIFEST.MF.

Use same versions for plugin as google-java-format and
strip versions from copied jar to avoid updating build.properties
and MANIFEST.MF.
@google-cla google-cla bot added the cla: yes label Jul 30, 2021
@cristatus
Copy link
Contributor Author

I have just built the latest plugin for eclipse from this branch,

google-java-format-eclipse-plugin-1.11.0.jar

Put the plugin jar inside the dropins folder.

If you are using eclipse with JDK-16 or later, add the following lines at the end of eclipse.ini:

--add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED
--add-exports=jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED
--add-exports=jdk.compiler/com.sun.tools.javac.parser=ALL-UNNAMED
--add-exports=jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED
--add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED

This was referenced Jul 30, 2021
@cushon
Copy link
Collaborator

cushon commented Jul 30, 2021

Thanks @cristatus!

I followed the updated instructions to build the plugin, and uploaded a copy to the release page for 1.11.0: https://github.com/google/google-java-format/releases/tag/v1.11.0

@cristatus
Copy link
Contributor Author

Thanks @cushon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants