-
Notifications
You must be signed in to change notification settings - Fork 869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add scripts to build native binary (using a container) #1045
Conversation
According to oracle/graal#1868, Perhaps bumping the version of |
f4a79ea
to
0373cd8
Compare
Hah! It now "works" - kind of. How cool is this? To make this fully ready for review as-is, from my side, I would need to do some more work to change the script to not use volumes in Before spending a bit more time to do that ^^^ I would love a signal from reviewers / project committers if this would be merged, when green? |
ad87d2b
to
b8908dc
Compare
https://docs.docker.com/build/guide/mounts/ for With that, this is now fully ready for review as-is, from my side. |
31d5cb0
to
081f57b
Compare
This uses a container to simplify GraalVM installation.
Thanks for investigating this! Is https://github.com/graalvm/setup-graalvm a potential alternative to using docker to set up GraalVM? |
It might - I hadn't seen (searched for) that approach. Why I personally prefer this route over a GitHub Actions based approach is that this make it very easy to use locally: Anyone who has Docker, even e.g. on a Mac or Windows, can launch With GitHub Actions, it's "only possible on (and "locked into") GitHub", which... I personally don't like much. What do you think? |
Thanks for the background. I think my preference here as a maintainer is to try to use the dependencies and process we already have, vs. replacing it with a new one. GitHub Actions isn't perfect, but one concrete benefit here is that it would provide a way to support mac binaries. |
OK, makes sense; then I'll try that approach! Some other day though, and I'll raise a separate new PR. |
Fixes #894 and fixes #868!
As is, this doesn't work yet, launching./build-natives.sh
fails with:[ERROR] Failed to execute goal org.graalvm.buildtools:native-maven-plugin:0.9.13:build (build-native) on project google-java-format: 'gu' tool wasn't found. This probably means that JDK at isn't a GraalVM distribution. -> [Help 1]What thisgu
tool which apparently comes with a GraalVM distribution, but isn't included in a Graal container base image?!@fmeum @cushon perhaps you would know and like to chime in here?PS: This includes #1044, so don't "squash merge" this PR, but merge that one (1044) first, then "rebase merge" this one, and only the 2nd commit would be merged, and 1st one dropped. (Or I could rebase this after that is merged, so this is cleaner, if requested.)