Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating martian to fix #google/martian/issues/309 #16

Merged
merged 2 commits into from
Mar 14, 2022

Conversation

phaus
Copy link
Contributor

@phaus phaus commented Mar 14, 2022

This change did remove the flag.Parse from the martian init function.

@phaus
Copy link
Contributor Author

phaus commented Mar 14, 2022

Sorry @jba to bother your again :-/.
To to do another change to have martian compatible with Golang 1.1.7.
Can you please merge and tag this one again? 🙏

@jba
Copy link
Collaborator

jba commented Mar 14, 2022

I don't want to make this package require Go 1.17 yet, because Go 1.16 is still supported.

In a few days we'll release Go 1.18, and then sometime shortly after that I'd be fine with this.

@jba jba merged commit db4189c into google:master Mar 14, 2022
@jba
Copy link
Collaborator

jba commented Mar 14, 2022

Pushed tag httpreplay/v1.1.1

@izturn
Copy link

izturn commented Jun 10, 2022

any progress? the martian v3.3.2 is conflict with corba @jba

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants