Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: add importer field to struct #881

Merged
merged 1 commit into from
Mar 29, 2018
Merged

misc: add importer field to struct #881

merged 1 commit into from
Mar 29, 2018

Conversation

appilon
Copy link
Contributor

@appilon appilon commented Mar 28, 2018

Adding importer ips to /meta struct

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@appilon
Copy link
Contributor Author

appilon commented Mar 28, 2018

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes Indication that the PR author has signed a Google Contributor License Agreement. and removed cla: no labels Mar 28, 2018
Copy link
Member

@dmitshur dmitshur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. This looks good. There's just one minor issue, see inline comment.

The GitHub API docs for this are at https://developer.github.com/v3/meta/.

github/misc.go Outdated
@@ -158,6 +158,10 @@ type APIMeta struct {
// An array of IP addresses in CIDR format specifying the addresses
// which serve GitHub Pages websites.
Pages []string `json:"pages,omitempty"`

// An Array of IP addresses specifying the addresses that source imports
// will originate from on GitHub.com
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor, but there should be a period at the end of this sentence. We want to have proper grammar and consistency.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

Copy link
Member

@dmitshur dmitshur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@dmitshur dmitshur requested a review from gmlewis March 28, 2018 17:58
@gmlewis
Copy link
Collaborator

gmlewis commented Mar 29, 2018

LGTM. Thank you, @appilon and @shurcooL!
Merging.

@gmlewis gmlewis merged commit 77c6f09 into google:master Mar 29, 2018
nbareil pushed a commit to nbareil/go-github that referenced this pull request May 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants