fix api preview header, missing :

[jurgenweber]

so then the api previews actually work. :)

[google-cla]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[jurgenweber]

@googlebot I signed it!

[jurgen-weber-deltatre]

considering all the failing CI, this doesn't seem to be the only place/thing I need to update but it is also making me second guess that this is the solution...

but for me, this works:

$ curl -v -XPOST -H "Accept: application/vnd.github.nebula-preview+json, application/vnd.github.v3+json" -H "Authorization: token XXXX" "https://api.github.com/orgs/myorg/repos" -d '{"name":"jurgen","visibility":"internal"}'

This does not:

$ curl -v -XPOST -H "Accept application/vnd.github.nebula-preview+json, application/vnd.github.v3+json" -H "Authorization: token XXXX" "https://api.github.com/orgs/myorg/repos" -d '{"name":"jurgen","visibility":"internal"}'

but it would mean these api previews are working for no one.

[gmlewis]

so then the api previews actually work. :)

I'm sorry, I don't understand why this change is necessary. This repo has been using custom preview headers for years now and they have been working well up to this point. Could you please explain what you saw that caused you to write this PR?

Also, you should be able to run "go test ./..." locally to make sure the unit tests pass.

[jurgen-weber-deltatre]

I'm sorry, I don't understand why this change is necessary. This repo has been using custom preview headers for years now and they have been working well up to this point.

Yeha, I agree.. Seems weird to me.

Could you please explain what you saw that caused you to write this PR?

#1786 (comment)

It was a long story to get to this point, but I feel there is some more to it. I started with using the terraform-provider-github and in the end I can not make internal repos using the provider. I have subsequently ended up here. I started replicating the provider commands with curl commands to ID what is going on.

The beginings of my journey are here; integrations/terraform-provider-github#662

If it isn't the headers, then I am not sure to why when using TF this fails.

GitHub support then pointed me to the concept of the API reviews and I noticed the string difference, using CURL the api call fails without a colon.

Also, you should be able to run "go test ./..." locally to make sure the unit tests pass.

Ok

[jurgen-weber-deltatre]

Just a follow up; I tried this locally (found some time this morning):

https://github.com/jurgenweber/go-github/blob/master/example/orgnewrepo/main.go

this works, so the problem is else wehre.

Thanks

[jurgenweber]

I found it; integrations/terraform-provider-github#680