-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable BranchRestriction fields to be empty #1530
Enable BranchRestriction fields to be empty #1530
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Codecov Report
@@ Coverage Diff @@
## master #1530 +/- ##
=======================================
Coverage 68.03% 68.03%
=======================================
Files 94 94
Lines 8528 8528
=======================================
Hits 5802 5802
Misses 1844 1844
Partials 882 882
Continue to review full report at Codecov.
|
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @michelangelomo !
LGTM.
Awaiting second LGTM before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👌
Thank you, @wesleimp ! |
Description
I've encountered an issue trying to update BranchRestriction on a personal repository. Github doesn't allow
teams
andusers
fields in the request payload.How to reproduce
will return
but if I set
Teams
andUsers
fields as[]string{}
Github returns422 Validation Failed [{Resource: Field: Code: Message:Only organization repositories can have users and team restrictions}]
as described above.Fix
Allow
Teams
andUsers
fields to be empty by usingomitempty
.