-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement support for repository visibility parameter #1471
Conversation
Implements support for specifying a repositories visibility. It can be one of public, private or internal (if the organization is associated with an enterprise account). The associated preview header (nebula) has also been added.
Codecov Report
@@ Coverage Diff @@
## master #1471 +/- ##
==========================================
+ Coverage 68.16% 68.17% +0.01%
==========================================
Files 94 94
Lines 8419 8422 +3
==========================================
+ Hits 5739 5742 +3
Misses 1819 1819
Partials 861 861
Continue to review full report at Codecov.
|
What is the release cadence for this project - I would like to put this to use in the Github Terraform Provider ASAP! |
We used to do a semver (major, minor, patch) release on each merged PR, but that got way too extreme... so now we release on demand. I can make a new release after this PR is merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @patrickmarabeas!
LGTM.
Awaiting second LGTM before merging.
Note to self: this is a non-breaking API change, and adds backward-compatible functionality, so this will be a minor release.
That would be great - thanks @gmlewis! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👌
Thank you, @wesleimp! |
@patrickmarabeas - Version |
Implements support for specifying a repositories visibility. It can be
one of public, private or internal (if the organization is associated
with an enterprise account).
The associated preview header (nebula) has also been added.
Resolves: #1470