Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

event_types.go: PushEvent and IssueCommentEvent are missing Organization (optional) field #2115

Closed
lluiscampos opened this issue Oct 5, 2021 · 0 comments · Fixed by #2116
Closed

event_types.go: PushEvent and IssueCommentEvent are missing Organization (optional) field #2115

lluiscampos opened this issue Oct 5, 2021 · 0 comments · Fixed by #2116

Comments

@lluiscampos
Copy link
Contributor

lluiscampos commented Oct 5, 2021 •
edited
Loading

According to GitHub documentation: "Webhook payloads contain the organization object when the webhook is configured for an organization or the event occurs from activity in a repository owned by an organization".

Currently, the Organization object is present for PullRequestEvent and others, but missing from PushEvent and IssueCommentEvent (and many others, but these two are the ones I need on my project).

References:
lluiscampos added a commit to lluiscampos/go-github that referenced this issue Oct 5, 2021
@lluiscampos
event_types.go: add Organization to PushEvent and IssueCommentEvent
41d12d0 
Fixes google#2115

This is an optional field present in most of the events payload. See:
* https://docs.github.com/en/developers/webhooks-and-events/webhooks/webhook-events-and-payloads#push
* https://docs.github.com/en/developers/webhooks-and-events/webhooks/webhook-events-and-payloads#issue_comment

Signed-off-by: Lluis Campos <[email protected]>
@lluiscampos lluiscampos mentioned this issue Oct 5, 2021
Merged
gmlewis pushed a commit that referenced this issue Oct 5, 2021
@lluiscampos
Add Organization to PushEvent and IssueCommentEvent (#2116)
c67c0c3 
Fixes: #2115.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

event_types.go: add Organization to PushEvent and IssueCommentEvent lluiscampos/go-github
1 participant
@lluiscampos