Skip to content

Commit

Permalink
Require Go 1.7 and newer. (#554)
Browse files Browse the repository at this point in the history
We need to do this in order to be able to resolve #526 without
unreasonable compromises.

That's the minimum version that has context package in standard
library, and built-in support for it inside net/http package.
Now that Go 1.8 is out, this "current version, plus one back".

Bump up the library version in anticipation of breaking API changes
in following commits. It makes sense to bump it now because this
commit drops support for Go versions 1.4, 1.5 and 1.6, so we can
say that version 2 is the latest supported by older Go versions.

Helps #526.
  • Loading branch information
dmitshur authored Feb 18, 2017
1 parent 82629e0 commit 796decd
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 12 deletions.
14 changes: 4 additions & 10 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,18 +1,12 @@
sudo: false
language: go
go:
- 1.5.4
- 1.6.3
- 1.7
- tip
- 1.7.x
- 1.8.x
- master
matrix:
include:
- go: 1.4.3
script:
- go get -t -v ./...
- go test -v -race ./...
allow_failures:
- go: tip
- go: master
fast_finish: true
install:
- # Do nothing. This is needed to prevent default install action "go get -t -v ./..." from happening here (we want it to happen inside script step).
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ go-github is a Go client library for accessing the [GitHub API][].
**Build Status:** [![Build Status](https://travis-ci.org/google/go-github.svg?branch=master)](https://travis-ci.org/google/go-github)
**Test Coverage:** [![Test Coverage](https://coveralls.io/repos/google/go-github/badge.svg?branch=master)](https://coveralls.io/r/google/go-github?branch=master) ([gocov report](https://drone.io/github.com/google/go-github/files/coverage.html))

go-github requires Go version 1.4 or greater.
go-github requires Go version 1.7 or greater.

## Usage ##

Expand Down
2 changes: 1 addition & 1 deletion github/github.go
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ const (
)

const (
libraryVersion = "2"
libraryVersion = "3"
defaultBaseURL = "https://api.github.com/"
uploadBaseURL = "https://uploads.github.com/"
userAgent = "go-github/" + libraryVersion
Expand Down

0 comments on commit 796decd

Please sign in to comment.