Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support WithJobs in remote.Write #958

Merged
merged 1 commit into from
Mar 11, 2021
Merged

Support WithJobs in remote.Write #958

merged 1 commit into from
Mar 11, 2021

Conversation

imjasonh
Copy link
Collaborator

@imjasonh imjasonh commented Mar 8, 2021

Holdover TODO from #803 that I noticed while working on progress updates

@imjasonh imjasonh requested a review from jonjohnsonjr March 8, 2021 19:55
@codecov-io
Copy link

Codecov Report

Merging #958 (6dc5698) into main (71a6fe9) will decrease coverage by 0.06%.
The diff coverage is 85.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #958      +/-   ##
==========================================
- Coverage   73.12%   73.05%   -0.07%     
==========================================
  Files         107      107              
  Lines        4781     4792      +11     
==========================================
+ Hits         3496     3501       +5     
- Misses        768      775       +7     
+ Partials      517      516       -1     
Impacted Files Coverage Δ
pkg/v1/remote/write.go 64.30% <85.18%> (-0.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71a6fe9...423fa15. Read the comment docs.

@imjasonh imjasonh merged commit 2f4c6f0 into google:main Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants