Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Automated] Update actions #773

Closed
wants to merge 1 commit into from
Closed

[Automated] Update actions #773

wants to merge 1 commit into from

Conversation

mattmoor
Copy link
Collaborator

Produced via:

# meta: knative/.github
# main: google/go-containerregistry
cp $(find "${GITHUB_WORKSPACE}/meta/workflow-templates" -type f -name '*.yaml') \
  "${GITHUB_WORKSPACE}/main/.github/workflows/"

/cc @jonjohnsonjr @imjasonh
/assign @jonjohnsonjr @imjasonh

@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2020 •
edited
Loading

Codecov Report

Merging #773 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #773   +/-   ##
=======================================
  Coverage   75.99%   75.99%           
=======================================
  Files         102      102           
  Lines        4132     4132           
=======================================
  Hits         3140     3140           
  Misses        542      542           
  Partials      450      450

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f2724c...e04f60d. Read the comment docs.

@mattmoor mattmoor mentioned this pull request Sep 25, 2020
Merged
@mattmoor mattmoor force-pushed the auto-updates/common-actions branch from c218182 to 2775a48 Compare September 25, 2020 01:47
@mattmoor
Copy link
Collaborator Author

I think there's a test in here that only works on GCP 😞

cc @imjasonh @jonjohnsonjr

@mattmoor
Copy link
Collaborator Author

Once this lands, we should send a PR like: ko-build/ko#197 to enable some more of the checks these pulled in.

@mattmoor mattmoor force-pushed the auto-updates/common-actions branch 2 times, most recently from 767591d to e04f60d Compare October 1, 2020 01:31
@mattmoor mattmoor force-pushed the auto-updates/common-actions branch from e04f60d to fa03a04 Compare October 7, 2020 01:34
@codecov-io
Copy link

codecov-io commented Oct 7, 2020 •
edited
Loading

Codecov Report

Merging #773 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #773   +/-   ##
=======================================
  Coverage   75.55%   75.55%           
=======================================
  Files         102      102           
  Lines        4169     4169           
=======================================
  Hits         3150     3150           
  Misses        565      565           
  Partials      454      454

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6344e57...05e29ff. Read the comment docs.

@mattmoor mattmoor force-pushed the auto-updates/common-actions branch 2 times, most recently from 107c2f8 to 3428fe8 Compare October 8, 2020 13:20
@imjasonh
Copy link
Collaborator

This fails some unit tests, which seemingly depend on GCR/Google specifically: https://github.com/google/go-containerregistry/pull/773/checks?check_run_id=1226113237

@mattmoor mattmoor force-pushed the auto-updates/common-actions branch 2 times, most recently from 5aa2396 to 39af275 Compare October 20, 2020 01:42
@mattmoor mattmoor force-pushed the auto-updates/common-actions branch from 39af275 to ca84d3c Compare October 21, 2020 03:54
@mattmoor
Update common github actions
05e29ff 
Signed-off-by: Matt Moore (via Sockpuppet) <[email protected]>
@mattmoor mattmoor force-pushed the auto-updates/common-actions branch from ca84d3c to 05e29ff Compare October 21, 2020 13:21
@mattmoor
Copy link
Collaborator Author

switching bots

@mattmoor mattmoor closed this Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mattmoor @codecov-commenter @codecov-io @imjasonh