-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use vdemeester/k8s-pkg-credentialprovider temporarly 🌬 #649
Use vdemeester/k8s-pkg-credentialprovider temporarly 🌬 #649
Conversation
This removes the dependency to `k8s.io/kubernetes` and use a "frozen in time" version of this package. This is temporary in the sense, that once kubernetes/enhancements#1406 is done, this will not be needed anymore and we should switch back to using it instead. Signed-off-by: Vincent Demeester <[email protected]>
Signed-off-by: Vincent Demeester <[email protected]>
The second commit updates the |
Codecov Report
@@ Coverage Diff @@
## master #649 +/- ##
======================================
Coverage 77.8% 77.8%
======================================
Files 102 102
Lines 4500 4500
======================================
Hits 3501 3501
Misses 583 583
Partials 416 416
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As much as I hate this, I don't think we really have another option. Thanks :)
@vdemeester I think this may have broken our image publishing stuff...
We might just need to update |
oh right, I guees so 🤔 I can try to take a look tomorrow 👼 |
ko-build/ko#119 might fix it edit: yup, images are published 😄 |
This removes the dependency to
k8s.io/kubernetes
and use a "frozenin time" version of this package.
This is temporary in the sense, that once
kubernetes/enhancements#1406 is done, this
will not be needed anymore and we should switch back to using it
instead.
/cc @jonjohnsonjr
Signed-off-by: Vincent Demeester [email protected]