Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use vdemeester/k8s-pkg-credentialprovider temporarly 🌬 #649

Merged

Conversation

vdemeester
Copy link
Contributor

This removes the dependency to k8s.io/kubernetes and use a "frozen
in time" version of this package.

This is temporary in the sense, that once
kubernetes/enhancements#1406 is done, this
will not be needed anymore and we should switch back to using it
instead.

/cc @jonjohnsonjr

Signed-off-by: Vincent Demeester [email protected]

This removes the dependency to `k8s.io/kubernetes` and use a "frozen
in time" version of this package.

This is temporary in the sense, that once
kubernetes/enhancements#1406 is done, this
will not be needed anymore and we should switch back to using it
instead.

Signed-off-by: Vincent Demeester <[email protected]>
Signed-off-by: Vincent Demeester <[email protected]>
@vdemeester
Copy link
Contributor Author

The second commit updates the vendor folder that didn't seem up-to-date 😅
Not sure if we should keep it or removing it 👼

@codecov-io
Copy link

codecov-io commented Jan 7, 2020

Codecov Report

Merging #649 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #649   +/-   ##
======================================
  Coverage    77.8%   77.8%           
======================================
  Files         102     102           
  Lines        4500    4500           
======================================
  Hits         3501    3501           
  Misses        583     583           
  Partials      416     416
Impacted Files Coverage Δ
pkg/authn/k8schain/k8schain.go 68.42% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b02f5c5...134ca65. Read the comment docs.

Copy link
Collaborator

@jonjohnsonjr jonjohnsonjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As much as I hate this, I don't think we really have another option. Thanks :)

@jonjohnsonjr jonjohnsonjr merged commit a1fca01 into google:master Jan 10, 2020
@vdemeester vdemeester deleted the tmp-using-forked-pkg-credential branch January 10, 2020 18:08
@jonjohnsonjr
Copy link
Collaborator

@vdemeester I think this may have broken our image publishing stuff... go get github.com/google/ko/cmd/ko fails with:

Step #0: build github.com/google/ko/cmd/ko: cannot load k8s.io/api/admissionregistration/v1alpha1: module k8s.io/api@latest found (v0.17.1), but does not contain package k8s.io/api/admissionregistration/v1alpha1

We might just need to update ko?

@vdemeester
Copy link
Contributor Author

oh right, I guees so 🤔 I can try to take a look tomorrow 👼

@jonjohnsonjr
Copy link
Collaborator

jonjohnsonjr commented Jan 15, 2020

ko-build/ko#119 might fix it

edit: yup, images are published 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants