Separate credentialprovider into files with buildtag π· #630
Conversation
|
/cc @jonjohnsonjr @imjasonh πΌ |
vdemeester
force-pushed
the
k8schain-provider-buildtags
branch
from
bbc65a3 to
3ed8b06
Compare
Codecov Report
@@ Coverage Diff @@
## master #630 +/- ##
=======================================
Coverage 76.29% 76.29%
=======================================
Files 101 101
Lines 4412 4412
=======================================
Hits 3366 3366
Misses 636 636
Partials 410 410
Continue to review full report at Codecov.
|
|
This seems reasonable to me, can you update the copyright year to 2019? Also this seems like a bug in kubernetes/kubernetes with the gcp credentialprovider. Is there an upstream bug? |
|
|
||
| package k8schain | ||
|
|
||
| // TODO(mattmoor): This doesn't seem to build, figure out why `dep ensure` |
There was a problem hiding this comment.
I think it might be worth just dropping this entirely.
Each files for each provider (aws, azure, gcp, β¦) have a "negative" build tag, this means by default, no behaviour change, they are all compiled β but they can be disabled using `disable-β¦`. This allows a library to depend on k8schain but not having those automatic import, or at least choose the one to enable/disable. Signed-off-by: Vincent Demeester <[email protected]>
vdemeester
force-pushed
the
k8schain-provider-buildtags
branch
from
3ed8b06 to
4a4db35
Compare
Done πΌ Didn't find an upstream bug, so created one: kubernetes/kubernetes#86245 |
Each files for each provider (aws, azure, gcp, β¦) have a "negative"
build tag, this means by default, no behaviour change, they are all
compiled β but they can be disabled using
disable-β¦.This allows a library to depend on k8schain but not having those
automatic import, or at least choose the one to enable/disable.
Signed-off-by: Vincent Demeester [email protected]