Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor pkg/name to use options #419

Merged
merged 2 commits into from
Mar 22, 2019

Conversation

jonjohnsonjr
Copy link
Collaborator

This changes the Strictness parameter to be a more general Option so
that we can also pass in name.Insecure for insecure registries.

Note that by changing the name.StrictValidation and name.WeakValidation
enums to be Options, this change avoids breaking callers or introducing
new methods.

Fixes #416

This changes the Strictness parameter to be a more general Option so
that we can also pass in name.Insecure for insecure registries.

Note that by changing the name.StrictValidation and name.WeakValidation
enums to be Options, this change avoids breaking callers or introducing
new methods.
@codecov-io
Copy link

codecov-io commented Mar 22, 2019

Codecov Report

Merging #419 into master will increase coverage by 0.12%.
The diff coverage is 96.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #419      +/-   ##
==========================================
+ Coverage   54.17%   54.29%   +0.12%     
==========================================
  Files          87       88       +1     
  Lines        4118     4129      +11     
==========================================
+ Hits         2231     2242      +11     
  Misses       1545     1545              
  Partials      342      342
Impacted Files Coverage Δ
pkg/name/check.go 100% <ø> (ø) ⬆️
pkg/name/registry.go 96% <100%> (-0.16%) ⬇️
pkg/name/tag.go 80.64% <100%> (+0.64%) ⬆️
pkg/name/options.go 100% <100%> (ø)
pkg/name/digest.go 77.77% <100%> (ø) ⬆️
pkg/name/ref.go 100% <100%> (ø) ⬆️
pkg/name/repository.go 80% <75%> (+0.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4391daf...9f34227. Read the comment docs.

@jonjohnsonjr jonjohnsonjr merged commit e1c5762 into google:master Mar 22, 2019
@jonjohnsonjr jonjohnsonjr deleted the name-options branch March 22, 2019 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants